Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency fix for Type Functions #1425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karl-police
Copy link
Contributor

@karl-police karl-police commented Sep 18, 2024

An alternate version of my fix for #1418

Where instead of changing the positions, I block the dependencies.

As the actual solution concept is just this: #1418 (comment)

The solution is to block all constraints that depend on the pending-expansion that is being expanded, on the resolution of the reduction constraint that is being created.

@karl-police karl-police force-pushed the type_function_solver_dependency_fix2 branch from 147f24f to 89550dd Compare September 18, 2024 15:56
@vegorov-rbx vegorov-rbx changed the title HUGE find, missing dependency fix for Type Functions, which also fixes a bug from the devforums Missing dependency fix for Type Functions Sep 18, 2024
@karl-police karl-police force-pushed the type_function_solver_dependency_fix2 branch from 89550dd to f8b2d16 Compare September 18, 2024 16:00
@karl-police karl-police force-pushed the type_function_solver_dependency_fix2 branch from f8b2d16 to 0f3102c Compare September 18, 2024 16:06
@karl-police
Copy link
Contributor Author

Though if the positions can also be forced at the location it would make certain solving faster :person_shrugging:

Let me know if I should change anything 🤷

@karl-police
Copy link
Contributor Author

karl-police commented Sep 18, 2024

image

welp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant